Fetch status of all scenarios in DM in a single operation instead of separately for each scenario. #7295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deployment-manger-db-queries
…deployment-manger-db-queries # Conflicts: # engine/flink/management/periodic/src/main/scala/pl/touk/nussknacker/engine/management/periodic/DeploymentActor.scala # engine/flink/management/periodic/src/main/scala/pl/touk/nussknacker/engine/management/periodic/PeriodicDeploymentManager.scala # engine/flink/management/periodic/src/main/scala/pl/touk/nussknacker/engine/management/periodic/PeriodicProcessService.scala # engine/flink/management/periodic/src/main/scala/pl/touk/nussknacker/engine/management/periodic/db/PeriodicProcessesRepository.scala # engine/flink/management/periodic/src/main/scala/pl/touk/nussknacker/engine/management/periodic/flink/FlinkJarManager.scala # engine/flink/management/periodic/src/main/scala/pl/touk/nussknacker/engine/management/periodic/model/DeploymentWithJarData.scala # engine/flink/management/periodic/src/main/scala/pl/touk/nussknacker/engine/management/periodic/model/PeriodicProcessDeployment.scala # engine/flink/management/periodic/src/main/scala/pl/touk/nussknacker/engine/management/periodic/model/SchedulesState.scala # engine/flink/management/periodic/src/main/scala/pl/touk/nussknacker/engine/management/periodic/service/AdditionalDeploymentDataProvider.scala # engine/flink/management/periodic/src/main/scala/pl/touk/nussknacker/engine/management/periodic/service/PeriodicProcessListener.scala # engine/flink/management/periodic/src/main/scala/pl/touk/nussknacker/engine/management/periodic/service/ProcessConfigEnricher.scala # engine/flink/management/periodic/src/test/scala/pl/touk/nussknacker/engine/management/periodic/DeploymentActorTest.scala # engine/flink/management/periodic/src/test/scala/pl/touk/nussknacker/engine/management/periodic/JarManagerStub.scala # engine/flink/management/periodic/src/test/scala/pl/touk/nussknacker/engine/management/periodic/PeriodicProcessDeploymentGen.scala # engine/flink/management/periodic/src/test/scala/pl/touk/nussknacker/engine/management/periodic/PeriodicProcessGen.scala # engine/flink/management/periodic/src/test/scala/pl/touk/nussknacker/engine/management/periodic/PeriodicProcessServiceTest.scala # engine/flink/management/periodic/src/test/scala/pl/touk/nussknacker/engine/management/periodic/db/InMemPeriodicProcessesRepository.scala
mgoworko
changed the title
…deployment-manger-db-queries
…deployment-manger-db-queries
|
created: #7358 |
mgoworko
changed the title
arkadius
reviewed
Dec 19, 2024
...in/scala/pl/touk/nussknacker/engine/management/FlinkStreamingDeploymentManagerProvider.scala
Outdated
Show resolved
Hide resolved
...manager-api/src/main/scala/pl/touk/nussknacker/engine/api/deployment/DeploymentManager.scala
Outdated
Show resolved
Hide resolved
...gner/server/src/main/scala/pl/touk/nussknacker/ui/process/deployment/DeploymentService.scala
Outdated
Show resolved
Hide resolved
...gner/server/src/main/scala/pl/touk/nussknacker/ui/process/deployment/DeploymentService.scala
Outdated
Show resolved
Hide resolved
...ic/src/test/scala/pl/touk/nussknacker/engine/management/periodic/DeploymentManagerStub.scala
Outdated
Show resolved
Hide resolved
...flink/management/src/main/scala/pl/touk/nussknacker/engine/management/FlinkRestManager.scala
Outdated
Show resolved
Hide resolved
…deployment-manger-db-queries
lciolecki
pushed a commit
that referenced
this pull request
Dec 23, 2024
…separately for each scenario. (#7295)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Problem to be solved:
When fetching list of scenarios or status of all scenarios, for periodic scenarios there were always 2N db queries for N periodic scenarios. Those 2N queries were performed each time and endpoint /processes or /processes/status was called.
Solution:
Defined capability of DeploymentManager (StateQueryForAllScenariosSupported). This capability means, that the DM can fetch all scenarios in a single operation.
The new capability is implemented for PeriodicDeploymentManager and for FlinkStreamingDeploymentManagerProvider (which is an underlying DM of PeriodicDeploymentManager)
When fetching processes or status, Nu uses the more efficient implementation of
StateQueryForAllScenariosSupportedwhen it is present (and it is present for periodics).This improvement can be implemented for other DM's too, but it is outside of the scope of this task. Moreover, we only have performance issues for periodic DM ATM.
Checklist before merge